Add plugin helper functions #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
force-pushed
the
plugin-helpers
branch
from
0769d3d
to
2263851
Compare
mszostok
force-pushed
the
plugin-helpers
branch
from
2263851
to
f9070a8
Compare
mszostok
requested review from
huseyinbabal and
pkosiec
and removed request for
huseyinbabal
pkosiec
reviewed
Jan 25, 2023
There was a problem hiding this comment.
The ParseCommand + MergeConfigs helpers could be useful, but I think the other ones don't belong here. They doesn't seem to be generic enough, and also use some shortucts like harcoded paths or modifying envs for current process. The DownloadDependencies will be not necessary anymore on Feburary 6th so I wouldn't keep it as official helper.
I think the solutions you provided are totally fine for the example executor purpose, so let's move most of the code there. In pluginx I would put something we actually use for our plugins.
We can discuss it offline, but please see my comments first 👍
mszostok
force-pushed
the
plugin-helpers
branch
3 times, most recently
from
e9799c2
to
2777f11
Compare
mszostok
force-pushed
the
plugin-helpers
branch
from
2777f11
to
ba5c5d1
Compare
|
I applied all fixed discussed offline. Once this PR will be merged, I will update our tutorials |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
They should simplify Botkube plugins development. First use: https://github.com/kubeshop/botkube-plugins-template/pull/7/files
(Some functions are opinionated as a given approach is required, e.g.
ParseCommand)I created it for 2 reason:
ghis more readable as we focus more on the core logic instead of some repeatable work like downloading or running binaries.However, if @botkube-dev you think that is sth that shouldn't be in our repository. I will extract that to a separate one under my GitHub handle.
Related issue(s)
#925