Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sorting of routes #82

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Add sorting of routes #82

merged 1 commit into from
Nov 10, 2021

Conversation

Tarick
Copy link
Contributor

@Tarick Tarick commented Nov 10, 2021

This PR...

Changes

  • adds sorting of routes by (exact path, regex, prefix) since Envoy chooses the first match in the list of routes.

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@Tarick Tarick added the bug label Nov 10, 2021
@Tarick Tarick added this to the alpha milestone Nov 10, 2021
@Tarick Tarick added this to In progress in kusk-gateway via automation Nov 10, 2021
@Tarick Tarick requested a review from dobegor November 10, 2021 10:05
@Tarick Tarick linked an issue Nov 10, 2021 that may be closed by this pull request
Routes order must be more specific #80
Closed
kusk-gateway automation moved this from In progress to Reviewer approved Nov 10, 2021
@Tarick Tarick merged commit 1139299 into main Nov 10, 2021
@Tarick Tarick deleted the tyatsurak/bug/80-routes-order-fix branch November 10, 2021 10:49
kusk-gateway automation moved this from Reviewer approved to Done Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehodgetts kylehodgetts kylehodgetts approved these changes

@dobegor dobegor dobegor approved these changes

Assignees
No one assigned
Labels
bug
Projects
No open projects
kusk-gateway
Done
Milestone
alpha
Development

Successfully merging this pull request may close these issues.

Routes order must be more specific
3 participants
@Tarick @kylehodgetts @dobegor