Ambassador - Provide possibility to disable everything at root level - with corresponding possibility to enable at path/method level #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 15, 2021 14:40
…anket disable on all operations on path and then can expose operations when they are deemed ready by overriding the disabled field at the operation level
and operations. Paths and Operations can then be enabled when they are deemed to be ready by overriding the disabled field at the path and field levels. Change disabled field in SubOptions from boolean to pointer to a boolean to implement the following semantics: - If nil, not explicitely set, then check for value at level above - if at operation, check path level. If at path level, check global level - If has a value be it True or False, disregard the disabled setting at the level above as it has been explicitely set Implement useful helper methods IsOperationDisabled and IsPathDisabled with the Option struct reciever which implement the semantics listed above
boolean pointer. Use Options helper methods for determining whether a path or operation is disabled
…ation is disabled
kylehodgetts
force-pushed
the
kylehodgetts/enhancement/148-hide-properties-default
branch
from
14f70cc
to
4dfda4d
Compare
kylehodgetts
changed the title
dobegor
approved these changes
Sep 15, 2021
kylehodgetts
deleted the
kylehodgetts/enhancement/148-hide-properties-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add global level disable option to enable blanket disable on all paths
and operations. Paths and Operations can then be enabled when they are
deemed to be ready by overriding the disabled field at the path and
field levels.
Change disabled field in SubOptions from boolean to pointer to a boolean
to implement the following semantics:
if at operation, check path level. If at path level, check global
level
the level above as it has been explicitely set
Implement useful helper methods IsOperationDisabled and IsPathDisabled
with the Option struct reciever which implement the semantics listed
above
resolves #148
Checklist