Nginx-Ingress - Provide possibility to disable everything at root level - with corresponding possibility to enable at path level #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 15, 2021 17:42
path has no kusk settings and thus enabled by default, kusk would skip it and not include it in the generated resources. This commit fixes this
disabled settings (Path > Global) take precendence. This is not implemented for operations as the nginx-ingress generator doesn't support operation level settings
Tarick
previously approved these changes
Sep 16, 2021
… checking rest of the kusk options when deciding whether or not to split into separate resources. This is to prevent an operation which is explicitely enabled being skipped because its corresponding path is disabled.
dobegor
approved these changes
Sep 16, 2021
kylehodgetts
deleted the
kylehodgetts/enhancement/148-hide-properties-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ambassador
Move path disabled checkout outside of the sub options look up. If a
path has no kusk settings and thus enabled by default, kusk would skip
it and not include it in the generated resources. This commit fixes this
Nginx-Ingress
Support disabled option resolution using the semantics where lower level
disabled settings (Path > Global) take precendence. This is not
implemented for operations as the nginx-ingress generator doesn't
support operation level settings
Checklist