Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite annotation value now correct when base path is set and trim prefix isnt #204

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Rewrite annotation value now correct when base path is set and trim prefix isnt #204

merged 2 commits into from
Dec 8, 2021

Conversation

kylehodgetts
Copy link
Contributor

This PR fixed #202

Changes

  • When setting rewrite annotation - append base path and then trim prefix only if trim prefix is set

Fixes

  • issue where base path wasnt included in rewrite annotation when base path is set and trim prefix isnt

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@kylehodgetts kylehodgetts self-assigned this Dec 8, 2021
@kylehodgetts kylehodgetts merged commit e92db60 into main Dec 8, 2021
@kylehodgetts kylehodgetts deleted the kylehodgetts/bugfix/202-incorrect-rewrite branch December 8, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tarick Tarick Tarick approved these changes

@dobegor dobegor dobegor approved these changes

@olensmar olensmar Awaiting requested review from olensmar

Assignees

@kylehodgetts kylehodgetts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect rewrite target generated for ingress-nginx when specifying path.base
3 participants
@kylehodgetts @Tarick @dobegor