Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Rename Resource" refactoring #211

Closed
olensmar opened this issue Aug 10, 2021 · 2 comments · Fixed by #361
Closed

"Rename Resource" refactoring #211

olensmar opened this issue Aug 10, 2021 · 2 comments · Fixed by #361
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@olensmar
Copy link
Member

When renaming a resource I would like Monokle to automatically update any incoming references to the resource based on the name - so for example changing the name of a configmap i would like any references to that configmap to be automatically updated.

This could be via a dedicated "Rename Resource" action in the navigator - with a corresponding hotkey and action in the editor itself

@olensmar olensmar added the enhancement New feature or request label Aug 10, 2021
@olensmar olensmar added this to the 1.2.0 release milestone Aug 20, 2021
@olensmar olensmar modified the milestones: 1.2.0 release, 1.1.0 release Aug 30, 2021
@olensmar
Copy link
Member Author

olensmar commented Sep 6, 2021

@tommywhitehead any thoughts on this? we would need to prompt the user for a new name - guessing we would do this as discussed for file-explorer actions previously - i.e. hamburger menu with actions?

@tommywhitehead
Copy link

tommywhitehead commented Sep 7, 2021

@olensmar I think a right-click menu (context menu) would be a good way to access a rename option. Once clicked, maybe a modal window would show with rename options.

I can mock up the modal window, what options are needed?

  • New name
  • Optional replace all links?
  • What else?

@devcatalin devcatalin self-assigned this Sep 9, 2021
@devcatalin devcatalin linked a pull request Sep 10, 2021 that will close this issue
4 tasks
@olensmar olensmar moved this from To do to Done in Resource creation/manipulation Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants