Skip to content

Commit

Permalink
feat: Custom container executor for Playwright - artifacts (#3867)
Browse files Browse the repository at this point in the history
* Playwright project - lock file aligned

* Playwright project - lock file aligned

* playwright artifacts tests

* custom container executor - playwright - artifacts
  • Loading branch information
tkonieczny committed May 21, 2023
1 parent b1f7cc6 commit bb330fc
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 13 deletions.
8 changes: 7 additions & 1 deletion test/container-executor/executor-smoke/crd/playwright.yaml
Expand Up @@ -14,4 +14,10 @@ spec:
uri: https://github.com/kubeshop/testkube
branch: main
path: test/playwright/executor-tests/playwright-project
workingDir: test/playwright/executor-tests/playwright-project
workingDir: test/playwright/executor-tests/playwright-project
executionRequest:
artifactRequest:
storageClassName: standard
volumeMountPath: /data/artifacts
dirs:
- ./
10 changes: 7 additions & 3 deletions test/executors/container-executor-playwright.yaml
Expand Up @@ -7,10 +7,12 @@ spec:
image: mcr.microsoft.com/playwright:v1.32.3-focal
command: ["/bin/sh", "-c"]
args:
- "npm install && CI=1 npx playwright test"
- "npm ci && CI=1 npx playwright test --output /data/artifacts"
executor_type: container
types:
- container-executor-playwright-v1.32.3/test
features:
- artifacts
---
apiVersion: executor.testkube.io/v1
kind: Executor
Expand All @@ -21,7 +23,9 @@ spec:
image: mcr.microsoft.com/playwright:v1.31.1-focal
command: ["/bin/sh", "-c"]
args:
- "npm install; npx playwright test"
- "npm ci; npx playwright test --output /data/artifacts"
executor_type: container
types:
- container-executor-playwright-v1.31.1/test
- container-executor-playwright-v1.31.1/test
features:
- artifacts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Expand Up @@ -8,6 +8,6 @@
"author": "",
"license": "ISC",
"devDependencies": {
"@playwright/test": "^1.32.3"
"@playwright/test": "1.32.3"
}
}

0 comments on commit bb330fc

Please sign in to comment.