Skip to content

Commit

Permalink
fix: use dll to open windows browser (#1631)
Browse files Browse the repository at this point in the history
  • Loading branch information
vsukhin committed Jun 9, 2022
1 parent 42eb3c7 commit e2dd210
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions cmd/kubectl-testkube/commands/dashboard.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"github.com/kubeshop/testkube/pkg/http"
"github.com/kubeshop/testkube/pkg/process"
"github.com/kubeshop/testkube/pkg/ui"
"github.com/skratchdot/open-golang/open"
"github.com/spf13/cobra"
)

Expand Down Expand Up @@ -69,11 +70,9 @@ func NewDashboardCmd() *cobra.Command {
ui.Debug("Endpoints readiness", fmt.Sprintf("%v", ready))

// open browser
openCmd, err := getOpenCommand()
if err == nil {
_, err = process.Execute(openCmd, dashboardAddress)
ui.PrintOnError("openning dashboard", err)
}
// open browser
err = open.Run(dashboardAddress)
ui.PrintOnError("openning dashboard", err)

// wait for Ctrl/Cmd + c signal to clear everything
c := make(chan os.Signal, 1)
Expand Down

0 comments on commit e2dd210

Please sign in to comment.