Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use net/http statuses #1792

Merged
merged 2 commits into from
Jul 13, 2022
Merged

fix: use net/http statuses #1792

merged 2 commits into from
Jul 13, 2022

Conversation

vsukhin
Copy link
Collaborator

@vsukhin vsukhin commented Jul 13, 2022

Pull request description

Use net/http statuses

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@vsukhin vsukhin requested review from exu, nicufk and vLia as code owners July 13, 2022 11:55
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #1792 (e9057ef) into main (0f49736) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head e9057ef differs from pull request most recent head 488e3f7. Consider uploading reports for the commit 488e3f7 to get more accurate results

@@          Coverage Diff          @@
##            main   #1792   +/-   ##
=====================================
  Coverage   9.17%   9.17%           
=====================================
  Files        119     119           
  Lines       6880    6900   +20     
=====================================
+ Hits         631     633    +2     
- Misses      6208    6226   +18     
  Partials      41      41           
Impacted Files Coverage Δ
internal/app/api/v1/executions.go 11.92% <0.00%> (-0.44%) ⬇️
internal/app/api/v1/executor.go 0.00% <0.00%> (ø)
internal/app/api/v1/tests.go 0.00% <0.00%> (ø)
internal/app/api/v1/testsuites.go 0.00% <0.00%> (ø)
internal/app/api/v1/webhook.go 0.00% <0.00%> (ø)
pkg/mapper/executions/summary.go 100.00% <0.00%> (ø)
pkg/api/v1/testkube/model_execution_extended.go 37.50% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f49736...488e3f7. Read the comment docs.

@vsukhin vsukhin merged commit bfe8751 into main Jul 13, 2022
@vsukhin vsukhin deleted the vsukhin/fix/api-tests-assertions branch July 13, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants