Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Testkube Swagger definition #1861

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Conversation

vLia
Copy link
Contributor

@vLia vLia commented Jul 20, 2022

Pull request description

While working on issue #1647 it came up that some of the already implemented properties from the Go code do not appear in the Swagger definition.
This commit makes sure that the newly generated models using make openapi-generate-model will not break old functionality.

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

  • updated swagger yaml to match go code

Fixes

While working on issue #1647 it came up that some of the already implemented properties from the Go code do not appear in the Swagger definition.
This commit makes sure that the newly generated models will not break old functionality.
Copy link
Collaborator

@vsukhin vsukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022

Codecov Report

Merging #1861 (d8303dd) into main (0635206) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #1861   +/-   ##
=====================================
  Coverage   9.05%   9.05%           
=====================================
  Files        120     120           
  Lines       7009    7009           
=====================================
  Hits         635     635           
  Misses      6332    6332           
  Partials      42      42           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0635206...d8303dd. Read the comment docs.

@vLia vLia merged commit e488121 into main Jul 20, 2022
@vLia vLia deleted the lilla/fix/update-swagger-yaml branch July 20, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants