Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create bug ticket #2003

Merged
merged 7 commits into from
Aug 5, 2022
Merged

feat: create bug ticket #2003

merged 7 commits into from
Aug 5, 2022

Conversation

vLia
Copy link
Contributor

@vLia vLia commented Aug 5, 2022

Pull request description

Closes #1937

This PR opens a browser with a new issue from the command line populating the versions and pointing to debug info to add more context.

Adding the exact logs this way is not possible due to URL size limitations - the body of the issue is added as a URL param.
Shortening the logs to match the size limitations ends us up with a few characters from each pod - in scaled up Testkube clusters this might be even worse.

Another option would be to create the Issue using the GitHub API without opening a browser window. This would depend to have logging into GitHub implemented which we currently don't have - and it is not worth the effort at this point.

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #2003 (5bc1d0d) into main (81a80f4) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #2003   +/-   ##
=====================================
  Coverage   9.13%   9.13%           
=====================================
  Files        122     122           
  Lines       7359    7359           
=====================================
  Hits         672     672           
  Misses      6642    6642           
  Partials      45      45           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@exu exu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

@vLia vLia merged commit b1e42aa into main Aug 5, 2022
@vLia vLia deleted the lilla/feat/create-bug-ticket branch August 5, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants