Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get all executor fields and store features #2582

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

vsukhin
Copy link
Collaborator

@vsukhin vsukhin commented Oct 20, 2022

Pull request description

Fix #2581

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

Copy link
Member

@nicufk nicufk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Base: 18.42% // Head: 18.37% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (ce3b255) compared to base (4070fc3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2582      +/-   ##
==========================================
- Coverage   18.42%   18.37%   -0.05%     
==========================================
  Files         180      180              
  Lines       11275    11293      +18     
==========================================
- Hits         2077     2075       -2     
- Misses       9048     9068      +20     
  Partials      150      150              
Impacted Files Coverage Δ
internal/app/api/v1/executor.go 0.00% <0.00%> (ø)
pkg/mapper/executors/mapper.go 0.00% <0.00%> (ø)
...kg/executor/containerexecutor/containerexecutor.go 45.54% <0.00%> (-1.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vsukhin vsukhin merged commit a5200a5 into main Oct 20, 2022
@vsukhin vsukhin deleted the vsukhin/fix/get-executor-save-features branch October 20, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private Registry (imagePullSecrets field in Executor entity) is not being set when calling the API from FE
3 participants