Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use execution names together with ids #2801

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

nicufk
Copy link
Member

@nicufk nicufk commented Nov 25, 2022

Pull request description

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@nicufk nicufk self-assigned this Nov 25, 2022
@nicufk nicufk marked this pull request as ready for review November 28, 2022 14:10
Copy link
Collaborator

@vsukhin vsukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. of course, it should be well tested

@nicufk nicufk force-pushed the nicolae/fix/use-name-for-ids-for-user--interactions branch from edf87f4 to b427090 Compare December 1, 2022 22:28
@codecov-commenter
Copy link

Codecov Report

Base: 18.69% // Head: 18.72% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (14e27d4) compared to base (2d6dde3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2801      +/-   ##
==========================================
+ Coverage   18.69%   18.72%   +0.02%     
==========================================
  Files         186      186              
  Lines       12772    12753      -19     
==========================================
  Hits         2388     2388              
+ Misses      10204    10185      -19     
  Partials      180      180              
Impacted Files Coverage Δ
internal/app/api/v1/executions.go 15.70% <0.00%> (-0.54%) ⬇️
internal/app/api/v1/testsuites.go 0.00% <0.00%> (ø)
...ernal/pkg/api/repository/result/mock_repository.go 31.66% <ø> (+1.50%) ⬆️
internal/pkg/api/repository/result/mongo.go 0.00% <0.00%> (ø)
...l/pkg/api/repository/testresult/mock_repository.go 11.53% <ø> (+0.74%) ⬆️
internal/pkg/api/repository/testresult/mongo.go 0.00% <0.00%> (ø)
pkg/scheduler/testsuite_scheduler.go 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nicufk nicufk merged commit ee4471d into main Dec 1, 2022
@nicufk nicufk deleted the nicolae/fix/use-name-for-ids-for-user--interactions branch December 1, 2022 22:57
@nicufk nicufk restored the nicolae/fix/use-name-for-ids-for-user--interactions branch December 22, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants