Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom container executor for Playwright - artifacts #3867

Merged
merged 4 commits into from
May 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,10 @@ spec:
uri: https://github.com/kubeshop/testkube
branch: main
path: test/playwright/executor-tests/playwright-project
workingDir: test/playwright/executor-tests/playwright-project
workingDir: test/playwright/executor-tests/playwright-project
executionRequest:
artifactRequest:
storageClassName: standard
volumeMountPath: /data/artifacts
dirs:
- ./
10 changes: 7 additions & 3 deletions test/executors/container-executor-playwright.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ spec:
image: mcr.microsoft.com/playwright:v1.32.3-focal
command: ["/bin/sh", "-c"]
args:
- "npm install && CI=1 npx playwright test"
- "npm ci && CI=1 npx playwright test --output /data/artifacts"
executor_type: container
types:
- container-executor-playwright-v1.32.3/test
features:
- artifacts
---
apiVersion: executor.testkube.io/v1
kind: Executor
Expand All @@ -21,7 +23,9 @@ spec:
image: mcr.microsoft.com/playwright:v1.31.1-focal
command: ["/bin/sh", "-c"]
args:
- "npm install; npx playwright test"
- "npm ci; npx playwright test --output /data/artifacts"
executor_type: container
types:
- container-executor-playwright-v1.31.1/test
- container-executor-playwright-v1.31.1/test
features:
- artifacts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
"author": "",
"license": "ISC",
"devDependencies": {
"@playwright/test": "^1.32.3"
"@playwright/test": "1.32.3"
}
}