Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove docker libssl upgrade #736

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

vsukhin
Copy link
Collaborator

@vsukhin vsukhin commented Jan 10, 2022

Pull request description

Remove libssl upgrade for latest alpine Docker image, because it alreday contains libssl1.1
It fixes issue #699

Proof:

docker run -it --rm alpine:latest ash
/ # apk --no-cache add ca-certificates libssl1.1
fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/community/x86_64/APKINDEX.tar.gz
(1/1) Installing ca-certificates (20191127-r7)
Executing busybox-1.34.1-r3.trigger
Executing ca-certificates-20191127-r7.trigger
OK: 6 MiB in 15 packages
/ # cd /lib
/lib # ls
apk                    libapk.so.3.12.0       libssl.so.1.1          mdev
firmware               libc.musl-x86_64.so.1  libz.so.1              modules-load.d
ld-musl-x86_64.so.1    libcrypto.so.1.1       libz.so.1.2.11         sysctl.d
/lib # strings /lib/libssl.so.1.1  | grep "OpenSSL 1.1.1"
OpenSSL 1.1.1l  24 Aug 2021

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

Remove libssl upgrade for Docker alpine image to libssl1.1

@vsukhin vsukhin requested review from a team, exu, olensmar and Toxer10 and removed request for a team January 10, 2022 13:24
Copy link
Member

@exu exu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@exu exu marked this pull request as ready for review January 10, 2022 13:26
@vsukhin vsukhin merged commit 62dcc37 into main Jan 10, 2022
@vsukhin vsukhin deleted the vsukhin/fix/remove-docker-libssl-upgrade branch January 10, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if libssl in api-server Dockerfile is still affected by secutity issues
4 participants