fix: better error messages and failed execution info #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exu
requested review from
fog1985,
jasmingacic,
nicufk and
vsukhin
as code owners
vsukhin
reviewed
Jan 26, 2022
| ) | ||
|
|
||
| return err | ||
| ui.Writer = writer |
There was a problem hiding this comment.
Is this thread safe? Write is a global var
There was a problem hiding this comment.
No, added comment to rewrite whole ui, to be able to get new instance with writer passed / I know this sucks ;) as this global is good for simple use cases - we can rethink this whole solution on some meeting with team
exu
commented
Jan 26, 2022
| ) | ||
|
|
||
| return err | ||
| ui.Writer = writer |
| ) | ||
|
|
||
| return err | ||
| ui.Writer = writer |
There was a problem hiding this comment.
No, added comment to rewrite whole ui, to be able to get new instance with writer passed / I know this sucks ;) as this global is good for simple use cases - we can rethink this whole solution on some meeting with team
| ) | ||
|
|
||
| return err | ||
| ui.Writer = writer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Fixing more edge cases in jobs execution
Checklist (choose whats happened)
Breaking changes
Changes
Fixes