feat(server): add endpoint to update test trigger response (#3117)

feat(server): add endpoint to update test trigger

api/grpc.yaml

@@ -31,8 +31,6 @@ components:
 
     GRPCResponse:
       type: object
-      required:
-        - statusCode
       properties:
         statusCode:
           type: integer

api/openapi.yaml

@@ -518,6 +518,29 @@ paths:
       responses:
         "204":
           description: OK
+    # TODO: remove this as soon as we refactor our queues
+    patch:
+      tags:
+        - api
+      parameters:
+        - $ref: "./parameters.yaml#/components/parameters/testId"
+        - $ref: "./parameters.yaml#/components/parameters/runId"
+      summary: "update a test run"
+      description: "update a test run"
+      operationId: updateTestRun
+      requestBody:
+        content:
+          application/json:
+            schema:
+              $ref: "./tests.yaml#/components/schemas/TestRun"
+      responses:
+        200:
+          description: successfuly updated the test run
+          content:
+            application/json:
+              schema:
+                $ref: "./tests.yaml#/components/schemas/TestRun"
+
   /tests/{testId}/definition:
     get:
       tags:

server/http/controller.go

@@ -708,3 +708,25 @@ func (c *controller) GetVersion(ctx context.Context) (openapi.ImplResponse, erro
 
 	return openapi.Response(http.StatusOK, version), nil
 }
+
+func (c *controller) UpdateTestRun(ctx context.Context, testID string, runID int32, testRun openapi.TestRun) (openapi.ImplResponse, error) {
+	existingRun, err := c.testRunRepository.GetRun(ctx, id.ID(testID), int(runID))
+	if err != nil {
+		return openapi.Response(http.StatusNotFound, err.Error()), err
+	}
+
+	run, err := c.mappers.In.Run(testRun)
+	if err != nil {
+		return openapi.Response(http.StatusBadRequest, err.Error()), err
+	}
+
+	// Prevents bad data in other fields to override correct data
+	existingRun.TriggerResult = run.TriggerResult
+
+	err = c.testRunRepository.UpdateRun(ctx, existingRun)
+	if err != nil {
+		return openapi.Response(http.StatusInternalServerError, err.Error()), err
+	}
+
+	return openapi.Response(http.StatusOK, run), err
+}

server/openapi/api.go

@@ -41,6 +41,7 @@ type ApiApiRouter interface {
 	RunTestSuite(http.ResponseWriter, *http.Request)
 	StopTestRun(http.ResponseWriter, *http.Request)
 	TestConnection(http.ResponseWriter, *http.Request)
+	UpdateTestRun(http.ResponseWriter, *http.Request)
 }
 
 // ResourceApiApiRouter defines the required methods for binding the api requests to a responses for the ResourceApiApi
@@ -112,6 +113,7 @@ type ApiApiServicer interface {
 	RunTestSuite(context.Context, string, RunInformation) (ImplResponse, error)
 	StopTestRun(context.Context, string, int32) (ImplResponse, error)
 	TestConnection(context.Context, DataStore) (ImplResponse, error)
+	UpdateTestRun(context.Context, string, int32, TestRun) (ImplResponse, error)
 }
 
 // ResourceApiApiServicer defines the api actions for the ResourceApiApi service

server/openapi/api_api.go

@@ -188,6 +188,12 @@ func (c *ApiApiController) Routes() Routes {
 			"/api/config/connection",
 			c.TestConnection,
 		},
+		{
+			"UpdateTestRun",
+			strings.ToUpper("Patch"),
+			"/api/tests/{testId}/run/{runId}",
+			c.UpdateTestRun,
+		},
 	}
 }
 
@@ -725,3 +731,36 @@ func (c *ApiApiController) TestConnection(w http.ResponseWriter, r *http.Request
 	EncodeJSONResponse(result.Body, &result.Code, w)
 
 }
+
+// UpdateTestRun - update a test run
+func (c *ApiApiController) UpdateTestRun(w http.ResponseWriter, r *http.Request) {
+	params := mux.Vars(r)
+	testIdParam := params["testId"]
+
+	runIdParam, err := parseInt32Parameter(params["runId"], true)
+	if err != nil {
+		c.errorHandler(w, r, &ParsingError{Err: err}, nil)
+		return
+	}
+
+	testRunParam := TestRun{}
+	d := json.NewDecoder(r.Body)
+	d.DisallowUnknownFields()
+	if err := d.Decode(&testRunParam); err != nil {
+		c.errorHandler(w, r, &ParsingError{Err: err}, nil)
+		return
+	}
+	if err := AssertTestRunRequired(testRunParam); err != nil {
+		c.errorHandler(w, r, err, nil)
+		return
+	}
+	result, err := c.service.UpdateTestRun(r.Context(), testIdParam, runIdParam, testRunParam)
+	// If an error occurred, encode the error with the status code
+	if err != nil {
+		c.errorHandler(w, r, err, &result)
+		return
+	}
+	// If no error, encode the body and the result code
+	EncodeJSONResponse(result.Body, &result.Code, w)
+
+}

server/openapi/model_grpc_response.go

@@ -10,7 +10,7 @@
 package openapi
 
 type GrpcResponse struct {
-	StatusCode int32 `json:"statusCode"`
+	StatusCode int32 `json:"statusCode,omitempty"`
 
 	Metadata []GrpcHeader `json:"metadata,omitempty"`
 
@@ -19,15 +19,6 @@ type GrpcResponse struct {
 
 // AssertGrpcResponseRequired checks if the required fields are not zero-ed
 func AssertGrpcResponseRequired(obj GrpcResponse) error {
-	elements := map[string]interface{}{
-		"statusCode": obj.StatusCode,
-	}
-	for name, el := range elements {
-		if isZero := IsZeroValue(el); isZero {
-			return &RequiredError{Field: name}
-		}
-	}
-
 	for _, el := range obj.Metadata {
 		if err := AssertGrpcHeaderRequired(el); err != nil {
 			return err