fix: run output unmarshal (#2882)

fix run output unmarshal
kubeshop · Jul 6, 2023 · 45b0239 · 45b0239
1 parent b38c37b
commit 45b0239
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 0 deletions.
diff --git a/server/test/test_json.go b/server/test/test_json.go
@@ -162,6 +162,28 @@ func (o *Outputs) UnmarshalJSON(data []byte) error {
 	return fmt.Errorf("test output json version is not supported. Expecting version 1 or 2")
 }
 
+func (output *RunOutput) UnmarshalJSON(data []byte) error {
+	obj := struct {
+		Name     string
+		Value    string
+		SpanID   string
+		Resolved bool
+		Error    string
+	}{}
+
+	err := json.Unmarshal(data, &obj)
+	if err != nil {
+		return err
+	}
+
+	output.Name = obj.Name
+	output.Value = obj.Value
+	output.SpanID = obj.SpanID
+	output.Resolved = obj.Resolved
+	output.Error = fmt.Errorf(obj.Error)
+	return nil
+}
+
 func (sar SpanAssertionResult) MarshalJSON() ([]byte, error) {
 	sid := ""
 	if sar.SpanID != nil {

diff --git a/server/test/test_json_test.go b/server/test/test_json_test.go
@@ -150,6 +150,27 @@ func TestOutputsV1(t *testing.T) {
 	assert.Equal(t, `attr:user_name`, testObject.Outputs[1].Value)
 }
 
+func TestXXX(t *testing.T) {
+	jsonData := `[
+		{
+			"Key": "http.host",
+			"Value": {
+				"Name": "http.host",
+				"Error": "",
+				"Value": "demo-pokemon-api.demo.svc.cluster.local",
+				"SpanID": "e28a7819ce8e0a01",
+				"Resolved": true
+			}
+		}
+	]`
+
+	run := test.Run{}
+	err := json.Unmarshal([]byte(jsonData), &run.Outputs)
+
+	require.NoError(t, err)
+	assert.Equal(t, run.Outputs.Len(), 1)
+}
+
 func TestOutputsV2(t *testing.T) {
 	v2Format := make([]test.Output, 0)
 	v2Format = append(v2Format, test.Output{