Skip to content

Commit

Permalink
Update the test connection behavior to just test when an unknown erro…
Browse files Browse the repository at this point in the history
…r happened
  • Loading branch information
danielbdias committed Apr 5, 2023
1 parent 12eeca4 commit 6dce506
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions server/executor/poller_executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@ package executor

import (
"context"
"errors"
"fmt"
"log"

"github.com/kubeshop/tracetest/server/model"
"github.com/kubeshop/tracetest/server/model/events"
"github.com/kubeshop/tracetest/server/tracedb"
"github.com/kubeshop/tracetest/server/tracedb/connection"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/trace"
)
Expand Down Expand Up @@ -123,8 +125,12 @@ func (pe DefaultPollerExecutor) ExecuteRequest(request *PollingRequest) (bool, s
traceID := run.TraceID.String()
trace, err := traceDB.GetTraceByID(request.ctx, traceID)
if err != nil {
// run test connection to give a diagnostic when an error happens
connectionResult := traceDB.TestConnection(request.ctx)
connectionResult := model.ConnectionResult{}

if !errors.Is(err, connection.ErrTraceNotFound) {
// run test connection to give a diagnostic when an unknown error happens
connectionResult = traceDB.TestConnection(request.ctx)
}

anotherErr := pe.eventEmitter.Emit(request.ctx, events.TraceFetchingError(request.test.ID, request.run.ID, connectionResult, err))
if anotherErr != nil {
Expand Down

0 comments on commit 6dce506

Please sign in to comment.