feat(sever): for test runs, split the failed state into more descript…

…ive statuses (#2310) Co-authored-by: Jorge Padilla <jorge.esteban.padilla@gmail.com>
kubeshop · Apr 5, 2023 · c186fbf · c186fbf
1 parent 36e42e7
commit c186fbf
Show file tree

Hide file tree

Showing 26 changed files with 384 additions and 265 deletions.
diff --git a/api/tests.yaml b/api/tests.yaml
@@ -128,7 +128,9 @@ components:
               AWAITING_TRACE,
               AWAITING_TEST_RESULTS,
               FINISHED,
-              FAILED,
+              TRIGGER_FAILED,
+              TRACE_FAILED,
+              ASSERTION_FAILED,
             ]
           description: Current execution state
         lastErrorState:

diff --git a/cli/actions/run_test_action.go b/cli/actions/run_test_action.go
@@ -19,6 +19,7 @@ import (
 	"github.com/kubeshop/tracetest/cli/formatters"
 	"github.com/kubeshop/tracetest/cli/openapi"
 	"github.com/kubeshop/tracetest/cli/ui"
+	"github.com/kubeshop/tracetest/cli/utils"
 	"github.com/kubeshop/tracetest/server/model/yaml"
 	"go.uber.org/zap"
 )
@@ -440,7 +441,7 @@ func (a runTestAction) transactionRun(ctx context.Context, transaction openapi.T
 	fmt.Print(formattedOutput)
 
 	if params.WaitForResult {
-		if tro.Run.GetState() == "FAILED" {
+		if utils.RunStateIsFailed(tro.Run.GetState()) {
 			// It failed, so we have to return an error status
 			os.Exit(1)
 		}
@@ -579,7 +580,7 @@ func (a runTestAction) isTestReady(ctx context.Context, testID, testRunId string
 		return &openapi.TestRun{}, fmt.Errorf("could not execute GetTestRun request: %w", err)
 	}
 
-	if *run.State == "FAILED" || *run.State == "FINISHED" {
+	if utils.RunStateIsFinished(run.GetState()) {
 		return run, nil
 	}
 
@@ -598,7 +599,7 @@ func (a runTestAction) isTransactionReady(ctx context.Context, transactionID, tr
 		return nil, fmt.Errorf("could not execute GetTestRun request: %w", err)
 	}
 
-	if *run.State == "FAILED" || *run.State == "FINISHED" {
+	if utils.RunStateIsFinished(run.GetState()) {
 		return run, nil
 	}
 

diff --git a/cli/formatters/test_run.go b/cli/formatters/test_run.go
@@ -7,6 +7,7 @@ import (
 
 	"github.com/kubeshop/tracetest/cli/config"
 	"github.com/kubeshop/tracetest/cli/openapi"
+	"github.com/kubeshop/tracetest/cli/utils"
 	"github.com/pterm/pterm"
 )
 
@@ -77,7 +78,7 @@ func (f testRun) json(output TestRunOutput) string {
 }
 
 func (f testRun) pretty(output TestRunOutput) string {
-	if output.Run.State != nil && *output.Run.State == "FAILED" {
+	if utils.RunStateIsFailed(output.Run.GetState()) {
 		return f.getColoredText(false, f.formatMessage("Failed to execute test: %s", *output.Run.LastErrorState))
 	}
 

diff --git a/cli/formatters/transaction_run.go b/cli/formatters/transaction_run.go
@@ -7,6 +7,7 @@ import (
 
 	"github.com/kubeshop/tracetest/cli/config"
 	"github.com/kubeshop/tracetest/cli/openapi"
+	"github.com/kubeshop/tracetest/cli/utils"
 	"github.com/pterm/pterm"
 )
 
@@ -78,7 +79,7 @@ func (f transactionRun) json(output TransactionRunOutput) string {
 }
 
 func (f transactionRun) pretty(output TransactionRunOutput) string {
-	if output.Run.GetState() == "FAILED" {
+	if utils.RunStateIsFailed(output.Run.GetState()) {
 		errorMessage := ""
 		if len(output.Run.Steps) > 0 {
 			lastStep := output.Run.Steps[len(output.Run.Steps)-1]