Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(server): rename configresource (#2797)
- Loading branch information
Showing
20 changed files
with
257 additions
and
267 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package config | ||
|
|
||
| import ( | ||
| "os" | ||
|
|
||
| "github.com/kubeshop/tracetest/server/pkg/id" | ||
| ) | ||
|
|
||
| type Config struct { | ||
| ID id.ID `json:"id"` | ||
| Name string `json:"name"` | ||
|
|
||
| AnalyticsEnabled bool `json:"analyticsEnabled"` | ||
| } | ||
|
|
||
| func (c Config) HasID() bool { | ||
| return c.ID.String() != "" | ||
| } | ||
|
|
||
| func (c Config) GetID() id.ID { | ||
| return c.ID | ||
| } | ||
|
|
||
| func (c Config) Validate() error { | ||
| return nil | ||
| } | ||
|
|
||
| func (c Config) IsAnalyticsEnabled() bool { | ||
| if os.Getenv("TRACETEST_DEV") != "" { | ||
| return false | ||
| } | ||
|
|
||
| return c.AnalyticsEnabled | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| package config_test | ||
|
|
||
| import ( | ||
| "context" | ||
| "os" | ||
| "testing" | ||
|
|
||
| "github.com/kubeshop/tracetest/server/config" | ||
| "github.com/kubeshop/tracetest/server/testmock" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/mock" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| type mockPublisher struct { | ||
| mock.Mock | ||
| } | ||
|
|
||
| func (m *mockPublisher) Publish(resourceID string, message any) { | ||
| m.Called(resourceID, message) | ||
| } | ||
|
|
||
| func TestPublishing(t *testing.T) { | ||
| restore := cleanEnv() | ||
| defer restore() | ||
|
|
||
| updated := config.Config{ | ||
| ID: "current", | ||
| Name: "Config", | ||
| AnalyticsEnabled: true, | ||
| } | ||
|
|
||
| publisher := new(mockPublisher) | ||
| publisher.Test(t) | ||
|
|
||
| publisher.On("Publish", config.ResourceID, updated) | ||
|
|
||
| repo := config.NewRepository( | ||
| testmock.CreateMigratedDatabase(), | ||
| config.WithPublisher(publisher), | ||
| ) | ||
|
|
||
| _, err := repo.Update(context.TODO(), updated) | ||
| require.NoError(t, err) | ||
|
|
||
| publisher.AssertExpectations(t) | ||
|
|
||
| } | ||
|
|
||
| func TestIsAnalyticsEnabled(t *testing.T) { | ||
| t.Run("DefaultValues", func(t *testing.T) { | ||
| restore := cleanEnv() | ||
| defer restore() | ||
|
|
||
| repo := config.NewRepository( | ||
| testmock.CreateMigratedDatabase(), | ||
| ) | ||
|
|
||
| cfg := repo.Current(context.TODO()) | ||
| assert.True(t, cfg.IsAnalyticsEnabled()) | ||
|
|
||
| }) | ||
|
|
||
| t.Run("FromRepo", func(t *testing.T) { | ||
| restore := cleanEnv() | ||
| defer restore() | ||
| repo := config.NewRepository( | ||
| testmock.CreateMigratedDatabase(), | ||
| ) | ||
| repo.Update(context.TODO(), config.Config{ | ||
| AnalyticsEnabled: false, | ||
| }) | ||
|
|
||
| cfg := repo.Current(context.TODO()) | ||
| assert.False(t, cfg.IsAnalyticsEnabled()) | ||
| }) | ||
|
|
||
| t.Run("EnvOverride", func(t *testing.T) { | ||
| restore := cleanEnv() | ||
| defer restore() | ||
| repo := config.NewRepository( | ||
| testmock.CreateMigratedDatabase(), | ||
| ) | ||
| repo.Update(context.TODO(), config.Config{ | ||
| AnalyticsEnabled: true, | ||
| }) | ||
|
|
||
| cfg := repo.Current(context.TODO()) | ||
|
|
||
| os.Setenv("TRACETEST_DEV", "yes") | ||
| assert.False(t, cfg.IsAnalyticsEnabled()) | ||
|
|
||
| }) | ||
| } | ||
|
|
||
| func cleanEnv() func() { | ||
| val := os.Getenv("TRACETEST_DEV") | ||
| // make sure this env is empty | ||
| os.Setenv("TRACETEST_DEV", "") | ||
| return func() { | ||
| os.Setenv("TRACETEST_DEV", val) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.