Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setup script #1012

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Fix setup script #1012

merged 1 commit into from
Jul 28, 2022

Conversation

schoren
Copy link
Collaborator

@schoren schoren commented Jul 28, 2022

This PR fixes the setup script when calling it remotely by removing the dependency on the local k8s/deploy-collector.sh script.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@schoren schoren closed this Jul 28, 2022
@schoren schoren reopened this Jul 28, 2022
@schoren schoren marked this pull request as draft July 28, 2022 13:32
@schoren schoren linked an issue Jul 28, 2022 that may be closed by this pull request
setup script breaks if executed outside the cloned repository #1010
Closed
@schoren schoren marked this pull request as ready for review July 28, 2022 14:51
mathnogueira
mathnogueira approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@mathnogueira mathnogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schoren schoren merged commit e093400 into main Jul 28, 2022
@schoren schoren deleted the fix-setup-script branch July 28, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathnogueira mathnogueira mathnogueira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setup script breaks if executed outside the cloned repository
2 participants
@schoren @mathnogueira