fix: make failed assertions to return the formatted duration field #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathnogueira
commented
Oct 24, 2022
Comment on lines
-63
to
-66
| if err != nil { | ||
| return leftValue.String(), rightValue.String(), err | ||
| } | ||
|
|
There was a problem hiding this comment.
If you look at the next lines, you will see that this err will be returned after formatting the duration fields. So it's safe to remove this condition.
jorgeepc
approved these changes
Oct 24, 2022
mathnogueira
commented
Oct 25, 2022
| - name: Install CLI intergation version (latest main) | ||
| run: | | ||
| export GOPATH=$(go env GOPATH) | ||
| go install -v github.com/kubeshop/tracetest/cli@latest | ||
| go install -v github.com/kubeshop/tracetest/cli@main |
There was a problem hiding this comment.
We were installing the latest released version instead of the latest main version.
mathnogueira
commented
Oct 25, 2022
Comment on lines
+301
to
+302
| # TRACETEST_CLI_MAIN="$(go env GOPATH)/bin/tracetest" \ | ||
| TRACETEST_CLI_MAIN="../cli/tracetest" \ |
There was a problem hiding this comment.
This will be rolledback after this is merged. Otherwise the tests will not pass due to a bug in the CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1421
Checklist