-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoC: allow running tracetest locally without dependencies #1611
Conversation
af0a407
to
c78b273
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few minor comments
@@ -26,14 +28,16 @@ var cfg = flag.String("config", "config.yaml", "path to the config file") | |||
func main() { | |||
|
|||
flag.Parse() | |||
root := flag.Arg(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have a default here. Probably some directory in the working directory, such as: ./.tracetest
or so.
} | ||
|
||
func (td *fsDB) Drop() error { | ||
panic("not implemented") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth implementing this because it's very simple:
panic("not implemented") | |
return os.RemoveAll(td.root) |
12eb664
to
676c9ff
Compare
This PR allows the server to run without dependencies by directly running the
tracetest-server
binary locally.It embed the web build in the server binary, and uses a (unfinished) filesystem based testDB.
To run this version, you need to checkout this branch and build (you need goreleaser installed):
This will create a
dist/[architecture]/tracetest-server
file. You can run that file to start the serverNow you need to run the server, passing a root "database" dir. This will hold your "ignorable" db (like runs and config) and your "persistable" db (tests, envs, transactions).
You can use the
tracetesting
dir from the project:Finally, go to
http://localhost:11633
Changes
Fixes
Checklist