chore: Speedup docker multiarch build #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schoren
force-pushed
the
speedup-docker-build
branch
from
213c6e2
to
af96959
Compare
mathnogueira
approved these changes
Dec 23, 2022
.github/workflows/deploy-main.yml
Outdated
| @@ -1,4 +1,4 @@ | |||
| name: Deploy main | |||
| name: Deploy main 2 | |||
schoren
force-pushed
the
speedup-docker-build
branch
2 times, most recently
from
5e7ff71
to
a4cf30b
Compare
schoren
force-pushed
the
speedup-docker-build
branch
from
a4cf30b
to
829d5d0
Compare
danielbdias
approved these changes
Jan 31, 2023
Dockerfile
Outdated
| FROM alpine AS release | ||
| # Enable machine-id on alpine-linux (https://gitlab.alpinelinux.org/alpine/aports/-/issues/8761) | ||
| RUN apk add dbus |
There was a problem hiding this comment.
We removed this lib on purpose because we were having a lot of problems with duplicate machineids on docker at the beginning of January. The PR with the fallback is here: #1797
mathnogueira
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the build pipeline to use more of goreleaser's features, and improving cache and parallelization. The end goal is to have faster multi arch docker builds, but also speed our pipelines in general.
This PR changes the deploy main and release pipelines. This has not been totally tested because the only way to really test is is to do a real deploy main and release. It has been tested up to a point where it shouldn't be different from the previos pipeline.
Example runss:
In both examples the pipeline fails because of invalid credentials, so everything works until the actual publishing of artifacts.