Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): pre fill selector when adding an output #1864

Merged
merged 5 commits into from
Jan 23, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Jan 23, 2023

This PR adds the logic to pre-fill the selector when adding a test output based on the current selected span. It also adds a link to the expressions docs in the test output form.

Changes

  • pre-fill selector in test output
  • add link to expressions docs in test output form

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom

https://www.loom.com/share/fd90c71d8795404191e3de1962b83e35

@jorgeepc jorgeepc self-assigned this Jan 23, 2023
@jorgeepc jorgeepc requested a review from xoscar January 23, 2023 17:37
@olha23
Copy link

olha23 commented Jan 23, 2023

@jorgeepc hey Jorge, can we please avoid that error message states for input? Save the test button is disable and it’s obvious that you need to enter attribute and name
Screenshot 2023-01-23 at 1 40 51 PM

@jorgeepc
Copy link
Contributor Author

@jorgeepc hey Jorge, can we please avoid that error message states for input? Save the test button is disable and it’s obvious that you need to enter attribute and name Screenshot 2023-01-23 at 1 40 51 PM

@olha23 yes makes sense. Let me change that 👍

@jorgeepc jorgeepc merged commit cf6b5fb into main Jan 23, 2023
@jorgeepc jorgeepc deleted the 1807-add-selected-span-output branch January 23, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to expressions docs in output form [Chaining V2] Prefill selector when adding an output
3 participants