feature: adding test run outputs UX/UI improvements #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
commented
Jan 26, 2023
| res.Add(output.Name, model.RunOutput{ | ||
| Value: output.Value, | ||
| Name: output.Name, | ||
| SpanID: output.SpanId, |
There was a problem hiding this comment.
Adding span id as part of the output object
xoscar
commented
Jan 26, 2023
| @@ -166,6 +166,7 @@ const RunDetailTest = ({run, testId}: IProps) => { | |||
| {!isTestSpecFormOpen && !isTestOutputFormOpen && ( | |||
| <S.TabsContainer> | |||
| <Tabs | |||
| activeKey={query.get('tab') || TABS.SPECS} | |||
There was a problem hiding this comment.
Allowing update based on the url change
xoscar
commented
Jan 26, 2023
| @@ -67,7 +69,7 @@ const SpanDetail = ({onCreateTestSpec = noop, searchText, span}: IProps) => { | |||
| value: `attr:${key}`, | |||
| }); | |||
|
|
|||
| onNavigateAndOpen(output); | |||
| onNavigateAndOpen({...output, spanId: span!.id}); | |||
xoscar
commented
Jan 26, 2023
| $isDeleted={isDeleted} | ||
| data-cy="output-item-container" | ||
| $isSelected={isSelected} | ||
| onClick={handleOutputClick} |
There was a problem hiding this comment.
Including click event
xoscar
commented
Jan 26, 2023
| } | ||
|
|
||
| const TestOutputMark = ({className, outputs}: IProps) => { | ||
| const {onSelectedOutputs} = useTestOutput(); |
There was a problem hiding this comment.
Updates the selected outputs on click
xoscar
commented
Jan 26, 2023
| const isDraftMode = useAppSelector(selectIsPending); | ||
|
|
||
| useEffect(() => { | ||
| dispatch(outputsInitiated(testOutputs)); | ||
|
|
||
| return () => { | ||
| dispatch(outputsReseted()); |
There was a problem hiding this comment.
Resets the outputs so we don't show them in following tests or other contexts
xoscar
commented
Jan 26, 2023
| selectSelectedEnvironmentValues, | ||
| selectOutputs, | ||
| withOutputsSelector, | ||
| (environmentValues, outputs, withOutputs) => { |
There was a problem hiding this comment.
Including outputs into the mix
jorgeepc
approved these changes
Jan 26, 2023
| @@ -48,6 +48,7 @@ const TestOutputForm = ({isEditing = false, isLoading = false, onCancel, onSubmi | |||
| onFinish={values => onSubmit(values, spanIdList[0])} | |||
| onValuesChange={onValidate} | |||
| > | |||
| <Form.Item name="spanId" /> | |||
There was a problem hiding this comment.
Do we need to send the spanID from the client?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the outputs UX/UI to be more interactive as now you can select spans based on outputs and vice-versa.
Changes
Fixes
Checklist
https://www.loom.com/share/cbc55581cbfc45108f4b3b9cd0a1a820