Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1894 fixing modal window height #1915

Merged
merged 1 commit into from
Jan 30, 2023
Merged

1894 fixing modal window height #1915

merged 1 commit into from
Jan 30, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Jan 30, 2023

This PR fixes the modal window height so users do not have to scroll to see the footer actions.

Changes

  • Updates the max height for modals

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar linked an issue Jan 30, 2023 that may be closed by this pull request
Fix the size of modal windows #1894
Closed
@xoscar xoscar self-assigned this Jan 30, 2023
@xoscar xoscar marked this pull request as ready for review January 30, 2023 20:45
@xoscar xoscar merged commit 3da4f67 into main Jan 30, 2023
@xoscar xoscar deleted the 1894-fix-the-size-of-modal-windows branch January 30, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@danielbdias danielbdias danielbdias approved these changes

Assignees

@xoscar xoscar

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the size of modal windows
3 participants
@xoscar @jorgeepc @danielbdias