Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): add outputs for each test in transaction page #1922

Merged
merged 5 commits into from
Feb 1, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Jan 31, 2023

This PR adds the ability to see outputs for each test that is part of a transaction in the transaction run page.

Changes

  • Add outputs in transaction run page

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom

https://www.loom.com/share/d37d5cdfbd9f47b4a0df16ece6bf4c65

Updated screenshot

Screenshot 2023-02-01 at 12 50 46

@jorgeepc jorgeepc self-assigned this Jan 31, 2023
@jorgeepc jorgeepc marked this pull request as ready for review January 31, 2023 22:23
@jorgeepc jorgeepc requested a review from xoscar January 31, 2023 22:25
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but I'm wondering if this would be a good fit for JSON values or large values in general 🤔

@jorgeepc
Copy link
Contributor Author

jorgeepc commented Feb 1, 2023

Code looks good, but I'm wondering if this would be a good fit for JSON values or large values in general 🤔

Nice catch @xoscar let me try that case to see how it looks

@jorgeepc jorgeepc merged commit 27c566e into main Feb 1, 2023
@jorgeepc jorgeepc deleted the 1523-add-outputs-transaction-page branch February 1, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chaining V2] Show Outputs for each of the execution steps
3 participants