New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ui): adding support for Datadog Data Store #1972
Conversation
fd085d5
to
d880978
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean and simple, GJ @danielbdias!
@@ -2,7 +2,7 @@ type: Test | |||
spec: | |||
id: W656Q0c4g | |||
name: http://app:8080 | |||
description: akadlkasjdf | |||
description: Calling Hello World API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the problem with akadlkasjdf
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My documentation OCD won't free me if I don't update this description 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @danielbdias looks great. I think we need to add some support in the server code too. Please take a look at
@jorgeepc nice catch, I thought there was a BE PR checking that scenario! |
c0a9bd3
to
f44bd90
Compare
type: DataStore | ||
spec: | ||
name: OpenTelemetry Collector pipeline | ||
type: otlp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the type be datadog
here? I know it's going to work with otlp, but to be able to display the proper selected option in the UI should we have datadog
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that we can change this for Datadog. I'll do this on the next PR, that handles examples and documentation.
This PR adds support for Datadog as trace data store. The configuration page follows the same model as the Lightstep and New Relic integrations:
Changes
Configuration -> Connecting to Data Stores -> Datadog
Fixes
Checklist