Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): adding support for Datadog Data Store #1972

Merged
merged 4 commits into from Feb 13, 2023

Conversation

danielbdias
Copy link
Contributor

@danielbdias danielbdias commented Feb 10, 2023

This PR adds support for Datadog as trace data store. The configuration page follows the same model as the Lightstep and New Relic integrations:

image

Changes

  • API Protos: add Datadog as a type of data source
  • UI: add configuration page for Datadog
  • Docs: added first documentation page on Configuration -> Connecting to Data Stores -> Datadog

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@danielbdias danielbdias changed the title Adding support for Datadog on Frontend chore(ui): adding support for Datadog Data Store Feb 10, 2023
@danielbdias danielbdias marked this pull request as ready for review February 10, 2023 20:00
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and simple, GJ @danielbdias!

@@ -2,7 +2,7 @@ type: Test
spec:
id: W656Q0c4g
name: http://app:8080
description: akadlkasjdf
description: Calling Hello World API
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the problem with akadlkasjdf?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My documentation OCD won't free me if I don't update this description 😂

Copy link
Contributor

@jorgeepc jorgeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xoscar
Copy link
Collaborator

xoscar commented Feb 10, 2023

@jorgeepc nice catch, I thought there was a BE PR checking that scenario!

type: DataStore
spec:
name: OpenTelemetry Collector pipeline
type: otlp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the type be datadog here? I know it's going to work with otlp, but to be able to display the proper selected option in the UI should we have datadog here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that we can change this for Datadog. I'll do this on the next PR, that handles examples and documentation.

@danielbdias danielbdias merged commit 3c7278c into main Feb 13, 2023
@danielbdias danielbdias deleted the add/datadog-data-source branch February 13, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants