Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate if server returns 404 error on inexisting id in demo and polling profile #2227

Merged
merged 2 commits into from Mar 21, 2023

Conversation

mathnogueira
Copy link
Member

This PR fixes the error which makes the CLI erase the content from the demo definition file if it has an id that doesn't exist on the server.

The same patch was applied to polling profile resources.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Copy link
Collaborator

@schoren schoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xoscar xoscar merged commit 9718e55 into main Mar 21, 2023
28 checks passed
@xoscar xoscar deleted the fix/cli-empty-file branch March 21, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants