Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: allowing default AWS authentication #2235

Merged
merged 3 commits into from Mar 23, 2023
Merged

feature: allowing default AWS authentication #2235

merged 3 commits into from Mar 23, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Mar 22, 2023 •
edited

This PR adds support for the AWS authentication, enabling users to assign IAM roles to the task containers where Tracetest is running from.

Changes

  • Adds skipping static credentials based on useDefaultAuth flag
  • Updates example to use this new technique

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

https://www.loom.com/share/a9a09d8c574c47d39bc864dd806d1c1c

@xoscar xoscar added the tracing backend Improve or implement support for a new tracing backend label Mar 22, 2023
@xoscar xoscar self-assigned this Mar 22, 2023
@xoscar xoscar linked an issue Mar 22, 2023 that may be closed by this pull request
Please support all AWS authentication methods for xray tests #2006
Closed
@xoscar xoscar marked this pull request as ready for review March 22, 2023 15:49
@xoscar xoscar requested a review from jorgeepc March 23, 2023 14:38
jorgeepc
jorgeepc approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@jorgeepc jorgeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xoscar xoscar merged commit e32538f into main Mar 23, 2023
27 checks passed
@xoscar xoscar deleted the 2006-please-support-all-aws-authentication-methods-for-xray-tests branch March 23, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@schoren schoren Awaiting requested review from schoren

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

@danielbdias danielbdias Awaiting requested review from danielbdias

Assignees

@xoscar xoscar

Labels
tracing backend Improve or implement support for a new tracing backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please support all AWS authentication methods for xray tests
2 participants
@xoscar @jorgeepc