Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): remove settings confirmation modal #2238

Merged
merged 4 commits into from Mar 24, 2023
Merged

fix(frontend): remove settings confirmation modal #2238

merged 4 commits into from Mar 24, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Mar 23, 2023 •
edited

This PR removes the saving confirmation modal from the following Settings tabs: Analytics, TracePolling and Demo.

Changes

  • Remove saving confirmation modal

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Screenshot

Screenshot 2023-03-23 at 12 22 39

@jorgeepc jorgeepc self-assigned this Mar 23, 2023
@jorgeepc jorgeepc requested a review from xoscar March 23, 2023 17:44
@jorgeepc jorgeepc merged commit ca77eb0 into main Mar 24, 2023
27 checks passed
@jorgeepc jorgeepc deleted the 2216-remove-confirmation-modal branch March 24, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

Assignees

@jorgeepc jorgeepc

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove save confirmation modal from Analytic, Trace Polling and Demo tab in settings
2 participants
@jorgeepc @xoscar