replace connection test result with structure from model package #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeepc
approved these changes
Mar 28, 2023
Comment on lines
+10
to
+19
| var ( | ||
| ProtocolHTTP Protocol = "http" | ||
| ProtocolGRPC Protocol = "grpc" | ||
| ) | ||
|
|
||
| var ( | ||
| StatusPassed Status = "passed" | ||
| StatusWarning Status = "warning" | ||
| StatusFailed Status = "failed" | ||
| ) |
There was a problem hiding this comment.
Looks good, one minor question, does it make sense to move this to the connection_test_result.go model? Or do you think the test_run_event model is a better place for this?
There was a problem hiding this comment.
Initially, I add them in the test_run_event. I moved them from there because it's used by connection package and it doesn't have any relation to the test_run_eventfile. That's why they are not together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the model for the test run event and replace the connection test structures with the one located in the model package
Checklist