Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test change to stop flaky test #2277

Merged
merged 1 commit into from Mar 30, 2023
Merged

Added test change to stop flaky test #2277

merged 1 commit into from Mar 30, 2023

Conversation

danielbdias
Copy link
Contributor

@danielbdias danielbdias commented Mar 29, 2023 •
edited

This PR aims to fix a problem on TestServerPrefix when running it on OSX.

Running make test inside ./server should correctly now.

Changes

  • Add one sync statement to avoid racing conditions on TestServerPrefix test (made with @mathnogueira ).

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

mathnogueira
mathnogueira approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@mathnogueira mathnogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielbdias danielbdias merged commit 3d31983 into main Mar 30, 2023
27 checks passed
@danielbdias danielbdias deleted the fix/flaky-test-on-mac-os branch March 30, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathnogueira mathnogueira mathnogueira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielbdias @mathnogueira