feat(frontend): add error handling for trace section #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeepc
force-pushed
the
2148-add-trace-error-handling
branch
from
f67da0e
to
fcc5c1f
Compare
jorgeepc
force-pushed
the
2148-add-trace-error-handling
branch
from
fcc5c1f
to
278f6c1
Compare
xoscar
approved these changes
Mar 31, 2023
| </> | ||
| ); | ||
|
|
||
| const failedHeader = ( |
There was a problem hiding this comment.
If these two blocks don't require anything from the props or local state and also just one of them is rendered at one time, can we create them outside of the rendering cycle?
|
|
||
| const TestRunService = () => ({ | ||
| getTestRunEventsByStage(events: TestRunEvent[], stage: TestRunStage) { | ||
| return events.filter(event => event.stage === stage); | ||
| }, | ||
|
|
||
| getTestRunEventsWithLastPolling(events: TestRunEvent[]) { |
There was a problem hiding this comment.
I like this, that we are already considering that we can have multiple polling events. GJ!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the error handling improvements related to the
Test Run Tracesection.Changes
Test Run Tracesection.Fixes
Checklist
Loom
https://www.loom.com/share/daa917492ce54142a22e08b3a5d5a59d