Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: emit unreachable host events for http and grpc triggers #2283

Merged
merged 2 commits into from Mar 31, 2023
Merged

feat: emit unreachable host events for http and grpc triggers #2283

merged 2 commits into from Mar 31, 2023

Conversation

mathnogueira
Copy link
Member

@mathnogueira mathnogueira commented Mar 31, 2023 •
edited

This PR adds events when trying to triggering http and grpc endpoints but they are unreachable

image

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@mathnogueira mathnogueira linked an issue Mar 31, 2023 that may be closed by this pull request
Add calls to the EventEmitter on Trigger execution (HTTP_UNREACHABLE_HOST_ERROR and GRPC_UNREACHABLE_HOST_ERROR events) #2265
Closed
@mathnogueira mathnogueira merged commit c4cd6c2 into main Mar 31, 2023
18 of 20 checks passed
@mathnogueira mathnogueira deleted the feat/http-grpc-events branch March 31, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbdias danielbdias danielbdias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mathnogueira @danielbdias