feat(frontend): add websocket subscription for test run events #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeepc
force-pushed
the
2293-add-ws-event=susbscription
branch
2 times, most recently
from
f1b7fc7
to
762e05f
Compare
jorgeepc
force-pushed
the
2293-add-ws-event=susbscription
branch
from
762e05f
to
b9c91e1
Compare
jorgeepc
commented
Apr 5, 2023
| @@ -38,15 +38,15 @@ const TestResults = ({onDelete, onEdit, onRevert}: IProps) => { | |||
| <S.Container> | |||
| <Header selectedSpan={selectedSpan!} totalFailedSpecs={totalFailedSpecs} totalPassedSpecs={totalPassedSpecs} /> | |||
|
|
|||
| {(isLoading || !assertionResults) && ( | |||
There was a problem hiding this comment.
Changing a weird loading logic in the TestSpecs component
danielbdias
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the websocket subscription for test run events.
Changes
Fixes
Checklist