Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pokeshop use-cases docs typos #2328

Merged
merged 1 commit into from Apr 9, 2023
Merged

Update Pokeshop use-cases docs typos #2328

merged 1 commit into from Apr 9, 2023

Conversation

maheshkasabe
Copy link
Contributor

@maheshkasabe maheshkasabe commented Apr 9, 2023 •
edited

This PR...

Changes

  • The command tracetest test -d test-definition.yml --wait-for-results was missing run. Fiixed it !

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@maheshkasabe maheshkasabe mentioned this pull request Apr 9, 2023
Closed
@danielbdias
Copy link
Contributor

@maheshkasabe Thanks for getting this typo!

@danielbdias danielbdias merged commit a12b1fe into kubeshop:main Apr 9, 2023
1 check passed
@kdhamric
Copy link
Collaborator

@maheshkasabe Appreciate the improvement / correction to the docs!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbdias danielbdias danielbdias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maheshkasabe @danielbdias @kdhamric