Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update server.md to add http server options for server #2338

Merged
merged 2 commits into from Apr 11, 2023
Merged

Update server.md to add http server options for server #2338

merged 2 commits into from Apr 11, 2023

Conversation

kdhamric
Copy link
Collaborator

Update server.md to add http server options for server, including TRACETEST_SERVER_HTTPPORT and TRACETEST_SERVER_PATHPREFIX

This PR...

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@kdhamric
Update server.md to add http server options for server
0aff370 
Update server.md to add http server  options for server, including TRACETEST_SERVER_HTTPPORT and TRACETEST_SERVER_PATHPREFIX
@kdhamric kdhamric mentioned this pull request Apr 11, 2023
Closed
schoren
schoren approved these changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@schoren schoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I would also add the config file version of those settings:

server:
  httpPort: 11633
  pathPrefix: /

adnanrahic
adnanrahic approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@adnanrahic adnanrahic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion to include a config file example as well.

docs/docs/configuration/server.md Outdated Show resolved Hide resolved
docs/docs/configuration/server.md Show resolved Hide resolved
@kdhamric @adnanrahic
Apply suggestions from code review
a7f6091 
Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
@kdhamric kdhamric merged commit 1800636 into main Apr 11, 2023
1 check passed
@kdhamric kdhamric deleted the server-config-patch-1 branch April 11, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schoren schoren schoren approved these changes

@jorgeepc jorgeepc jorgeepc approved these changes

@danielbdias danielbdias danielbdias approved these changes

@adnanrahic adnanrahic adnanrahic approved these changes

@jfermi jfermi jfermi approved these changes

@xoscar xoscar Awaiting requested review from xoscar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kdhamric @schoren @jorgeepc @danielbdias @adnanrahic @jfermi