Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Added Running a Python app with Opentelemetry manual instrumention #2380

Merged
merged 20 commits into from Apr 21, 2023
Merged

[docs] Added Running a Python app with Opentelemetry manual instrumention #2380

merged 20 commits into from Apr 21, 2023

Conversation

maheshkasabe
Copy link
Contributor

@maheshkasabe maheshkasabe commented Apr 13, 2023 •
edited

This PR...

Changes

  • Added Python app running with tracetest tutorial with otel instrumentation

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@adnanrahic adnanrahic self-assigned this Apr 14, 2023
@adnanrahic
Copy link
Contributor

Hey @maheshkasabe ! Thanks a lot for your contribution. This is awesome. I'll jump on and review this as soon as possible.

adnanrahic
adnanrahic requested changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@adnanrahic adnanrahic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome contribution! I've added some suggestions I believe will improve the recipe! 🙌

.../examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md Outdated Show resolved Hide resolved
.../examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md Outdated Show resolved Hide resolved
.../examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md Outdated Show resolved Hide resolved
.../examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md Outdated Show resolved Hide resolved
.../examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md Outdated Show resolved Hide resolved
.../examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md Outdated Show resolved Hide resolved
.../examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md Outdated Show resolved Hide resolved
.../examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md Outdated Show resolved Hide resolved
.../examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md Outdated Show resolved Hide resolved
.../examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md Show resolved Hide resolved
maheshkasabe and others added 16 commits April 18, 2023 19:21
@maheshkasabe @adnanrahic
Update docs/docs/examples-tutorials/recipes/running-python-app-with-o…
7e3be41 
…pentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>
@maheshkasabe @adnanrahic
Update docs/docs/examples-tutorials/recipes/running-python-app-with-o…
fb52288 
…pentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>
@maheshkasabe @adnanrahic
Update docs/docs/examples-tutorials/recipes/running-python-app-with-o…
cd5b76a 
…pentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>
@maheshkasabe @adnanrahic
Update docs/docs/examples-tutorials/recipes/running-python-app-with-o…
897195d 
…pentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>
@maheshkasabe @adnanrahic
Update docs/docs/examples-tutorials/recipes/running-python-app-with-o…
487e3e1 
…pentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>
@maheshkasabe @adnanrahic
Update docs/docs/examples-tutorials/recipes/running-python-app-with-o…
3633c5e 
…pentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>
@maheshkasabe @adnanrahic
Update docs/docs/examples-tutorials/recipes/running-python-app-with-o…
766a39a 
…pentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>
@maheshkasabe @adnanrahic
Update docs/docs/examples-tutorials/recipes/running-python-app-with-o…
7ff6f97 
…pentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>
@maheshkasabe @adnanrahic
Update docs/docs/examples-tutorials/recipes/running-python-app-with-o…
47ee8c7 
…pentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>
@maheshkasabe @adnanrahic
Update docs/docs/examples-tutorials/recipes/running-python-app-with-o…
2aa9178 
…pentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>
@maheshkasabe @adnanrahic
Update docs/docs/examples-tutorials/recipes/running-python-app-with-o…
8b26150 
…pentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>
@maheshkasabe @adnanrahic
Update docs/docs/examples-tutorials/recipes/running-python-app-with-o…
c78fbca 
…pentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>
@maheshkasabe @adnanrahic
Update docs/docs/examples-tutorials/recipes/running-python-app-with-o…
224452b 
…pentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>
@maheshkasabe @adnanrahic
Update docs/docs/examples-tutorials/recipes/running-python-app-with-o…
443cc3c 
…pentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>
@maheshkasabe
Merge branch 'kubeshop:main' into main
d717766
@maheshkasabe
Update running-python-app-with-opentelemetry-collector-and-tracetest.md
f3619dc
@adnanrahic adnanrahic self-requested a review April 19, 2023 05:38
adnanrahic
adnanrahic requested changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@adnanrahic adnanrahic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment.

.../examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md Show resolved Hide resolved
@adnanrahic adnanrahic self-requested a review April 20, 2023 05:39
adnanrahic
adnanrahic approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@adnanrahic adnanrahic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @maheshkasabe!
Thanks a lot for contributing this recipe. 🙌

@xoscar xoscar merged commit e8bce0a into kubeshop:main Apr 21, 2023
1 check passed
schoren pushed a commit that referenced this pull request Jun 5, 2023
@maheshkasabe @adnanrahic @schoren
[docs] Added Running a Python app with Opentelemetry manual instrumen…
5594aa5 
…tion (#2380)

* [docs]Added Running a Python app with Opentelemetry manual instrumention

* Update docs/docs/examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>

* Update docs/docs/examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>

* Update docs/docs/examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>

* Update docs/docs/examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>

* Update docs/docs/examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>

* Update docs/docs/examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>

* Update docs/docs/examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>

* Update docs/docs/examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>

* Update docs/docs/examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>

* Update docs/docs/examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>

* Update docs/docs/examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>

* Update docs/docs/examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>

* Update docs/docs/examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>

* Update docs/docs/examples-tutorials/recipes/running-python-app-with-opentelemetry-collector-and-tracetest.md

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>

* Update running-python-app-with-opentelemetry-collector-and-tracetest.md

* Update running-python-app-with-opentelemetry-collector-and-tracetest.md

---------

Co-authored-by: Adnan Rahić <ado.raha198@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnanrahic adnanrahic adnanrahic approved these changes

Assignees

@adnanrahic adnanrahic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maheshkasabe @adnanrahic @xoscar