Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding customJSON comparer to RM tests #2393

Merged
merged 1 commit into from Apr 14, 2023
Merged

Adding customJSON comparer to RM tests #2393

merged 1 commit into from Apr 14, 2023

Conversation

danielbdias
Copy link
Contributor

This PR adds a new JSON comparer on ResourceManager tests, to help with custom comparisons like this one that I needed to build while migrating DataStores to RM.

Changes

  • Add support to custom JSON comparer on ResourceManager tests

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

schoren
schoren approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@schoren schoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielbdias danielbdias merged commit fa45a49 into main Apr 14, 2023
27 of 30 checks passed
@danielbdias danielbdias deleted the add/custom-json-formatter-for-rm-tests branch April 14, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schoren schoren schoren approved these changes

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielbdias @schoren