Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix TRACETEST_DEV in k8s installer #2395

Merged
merged 1 commit into from Apr 17, 2023

Conversation

jorgeepc
Copy link
Contributor

This PR applies a fix to the installer to allow us to use the TRACETEST_DEV environment variable in our shell to populate the value in the k8s deployment.

Changes

  • CLI installer fix

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@jorgeepc jorgeepc self-assigned this Apr 14, 2023
@jorgeepc jorgeepc added the CLI label Apr 14, 2023
@jorgeepc jorgeepc marked this pull request as ready for review April 14, 2023 21:30
Copy link
Collaborator

@schoren schoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xoscar
Copy link
Collaborator

xoscar commented Apr 14, 2023

🚢

@jorgeepc jorgeepc merged commit 95c738c into main Apr 17, 2023
27 checks passed
@jorgeepc jorgeepc deleted the 2349-fix-tracetest_dev_env branch April 17, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use TRACETEST_DEV env var from the shell in k8s deployment
4 participants