Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(frontend): improving error messaging for the trace results #2398

Merged
merged 1 commit into from Apr 17, 2023
Merged

feature(frontend): improving error messaging for the trace results #2398

merged 1 commit into from Apr 17, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Apr 17, 2023

This PR improves the error messaging from the trace section

Changes

  • Adds a link to the settings page when the data store connection fails
  • Includes the trace id as part of the error message if the poller times out

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

https://www.loom.com/share/a0ce8f8c0a36499c8323ff4cb914a639

@xoscar xoscar self-assigned this Apr 17, 2023
@xoscar xoscar linked an issue Apr 17, 2023 that may be closed by this pull request
[Error Handling] - Enhance trace error handling messaging #2389
Closed
@xoscar xoscar marked this pull request as ready for review April 17, 2023 18:02
@xoscar xoscar merged commit afe6915 into main Apr 17, 2023
28 checks passed
@xoscar xoscar deleted the 2389-error-handling-enhance-trace-error-handling-messaging branch April 17, 2023 19:21
schoren pushed a commit that referenced this pull request Jun 5, 2023
@xoscar @schoren
feature(frontend): improving error messaging for the trace results (#…
90aa664 
…2398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@schoren schoren Awaiting requested review from schoren

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

@danielbdias danielbdias Awaiting requested review from danielbdias

Assignees

@xoscar xoscar

Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Error Handling] - Enhance trace error handling messaging
2 participants
@xoscar @jorgeepc