Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): improve test specs error handling #2399

Merged
merged 3 commits into from Apr 19, 2023
Merged

feat(frontend): improve test specs error handling #2399

merged 3 commits into from Apr 19, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Apr 17, 2023 •
edited

This PR adds support for errors in Test Specs. Now we are including an error icon in the list of specs, and also the error message as part of the detail screen.

Changes

  • Support for errors in Test Specs

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Screenshots

Screenshot 2023-04-19 at 10 03 53

Screenshot 2023-04-19 at 10 03 58

Loom

https://www.loom.com/share/b1b776e5f20e4208b71bb3d91f0b3eeb

@jorgeepc jorgeepc self-assigned this Apr 17, 2023
@jorgeepc jorgeepc marked this pull request as ready for review April 17, 2023 22:28
xoscar
xoscar approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small non-blocking things:

  1. could the alert be part of the test spec header instead?
  2. Can we display the error message in the tooltip?

Great job dude! 🔥

@jorgeepc
Copy link
Contributor Author

Hey thanks for the feedback dude! @xoscar

  1. could the alert be part of the test spec header instead?
    With the alert do you mean the error message? The thing is that we don't have one single error, we can have one error for each assertion (inside the same test spec).
  1. Can we display the error message in the tooltip?
    Same thing here, we can have multiple errors, maybe we can display the first one?

@jorgeepc jorgeepc merged commit b211895 into main Apr 19, 2023
28 checks passed
@jorgeepc jorgeepc deleted the 2256-error-handling-test-specs branch April 19, 2023 15:59
schoren pushed a commit that referenced this pull request Jun 5, 2023
@jorgeepc @schoren
feat(frontend): improve test specs error handling (#2399)
9d789b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

Assignees

@jorgeepc jorgeepc

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Error Handling] Test section improvements
2 participants
@jorgeepc @xoscar