feature(backend): Adding support for HTTP OTLP server #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
commented
Apr 19, 2023
examples/quick-start-jaeger-nodejs/tracetest/collector.config.yaml
Outdated
Show resolved
Hide resolved
mathnogueira
requested changes
Apr 20, 2023
examples/quick-start-jaeger-nodejs/tracetest/collector.config.yaml
Outdated
Show resolved
Hide resolved
xoscar
changed the title
xoscar
commented
Apr 21, 2023
schoren
requested changes
Apr 21, 2023
server/otlp/exporter.go
Outdated
| db model.Repository | ||
|
|
||
| gServer *grpc.Server | ||
| type IExporter interface { |
There was a problem hiding this comment.
We usually don't prefix interfaces with I in go. Also it looks like this interface is not really required. You can just reference the actual struct. And given that this is only used internally within this package, you can even unexport it (a.k.a lowercasing the first letter)
server/otlp/exporter.go
Outdated
| addr: addr, | ||
| db: db, | ||
| } | ||
| type Exporter struct { |
There was a problem hiding this comment.
It's a bit weird that an Exporter only exposes an Ingest method. I would rename either the struct or the method to look a bit more consistent
There was a problem hiding this comment.
Again, you can unexport this struct, since it's only directly referenced within the package
schoren
requested changes
Apr 24, 2023
|
|
||
| func (s *httpServer) Start() error { | ||
| r := mux.NewRouter() | ||
| r.HandleFunc("/v1/traces", s.Export).Methods("POST") |
schoren
approved these changes
Apr 24, 2023
mathnogueira
approved these changes
Apr 24, 2023
xoscar
deleted the
2383-network-improvements-ease-networking-knowledge-needed-to-use-tracetest-1
branch
schoren
pushed a commit
that referenced
this pull request
Jun 5, 2023
* creating http otlp server * cleanup changes * cleanup changes * fixing example * enabling JSON request body for the OTLP HTTP endpoint * PR comments * PR comments * test * manually installing dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the tracetest server to spin off an OTLP http port that listens to incoming spans
Changes
Fixes
Checklist
https://www.loom.com/share/e05c8a794a3c47dcb660121f23ca58ee