Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding database connection cleanup procedure on Resource Manager tests #2418

Merged
merged 1 commit into from Apr 21, 2023

Conversation

danielbdias
Copy link
Contributor

This PR adds a database connection cleanup on RM tests to avoid surpassing PG connection capabilities when testing a package.

Changes

  • Changed RM tests to receive a database connection
  • Added code to manage database connection cleanup on Resource Manager tests

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Copy link
Collaborator

@schoren schoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a huge improvement!

@danielbdias danielbdias merged commit 3980f16 into main Apr 21, 2023
28 checks passed
@danielbdias danielbdias deleted the add/test-cleanup-capability-on-rm branch April 21, 2023 13:54
schoren pushed a commit that referenced this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants