Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cicd): replace cache with arctifacts so pipeline fails on error #2421

Merged
merged 1 commit into from Apr 24, 2023

Conversation

schoren
Copy link
Collaborator

@schoren schoren commented Apr 21, 2023

This PR replaces method for transmitting builds between the steps of the deploy main pipline from a cache to an arctifact. The difference is that an cache will fail silently to upload or download, while an arctifact fully fails on error.

This prevents issues like on this run, where the pipeline succeeded but the actual result was a nightly release with the linux binaries missing.

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@schoren schoren merged commit 4725c59 into main Apr 24, 2023
1 check passed
@schoren schoren deleted the fix-pipeline branch April 24, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants