Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(backend): fixing url parsing for http requests #2430

Merged
merged 1 commit into from Apr 24, 2023
Merged

bug(backend): fixing url parsing for http requests #2430

merged 1 commit into from Apr 24, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Apr 24, 2023

This PR fixes the HTTP url parsing by introducing a library that resolves the strings in a proper way

Changes

  • Includes urlx to parse http triggers

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Check what URLX does instead of whatever the core url package tries to do:

Screenshot 2023-04-24 at 13 49 01

@xoscar xoscar self-assigned this Apr 24, 2023
@xoscar xoscar marked this pull request as ready for review April 24, 2023 19:50
@xoscar xoscar merged commit 7c2e285 into main Apr 24, 2023
30 checks passed
@xoscar xoscar deleted the fixing-trigger-url-parsing branch April 24, 2023 20:19
schoren pushed a commit that referenced this pull request Jun 5, 2023
@xoscar @schoren
bug(backend): fixing url parsing for http requests (#2430)
9db1911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@schoren schoren Awaiting requested review from schoren

@povilasv povilasv Awaiting requested review from povilasv

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xoscar @jorgeepc