Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil reference error when starting Tempo #2444

Merged
merged 1 commit into from Apr 26, 2023
Merged

Fix nil reference error when starting Tempo #2444

merged 1 commit into from Apr 26, 2023

Conversation

danielbdias
Copy link
Contributor

This PR fixes a server crash error that happens when we configure Tempo Cloud with HTTP client

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

jorgeepc
jorgeepc approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@jorgeepc jorgeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@danielbdias danielbdias merged commit 897e8a8 into main Apr 26, 2023
28 checks passed
@danielbdias danielbdias deleted the fix/tempo-cloud-config branch April 26, 2023 21:44
schoren pushed a commit that referenced this pull request Jun 5, 2023
@danielbdias @schoren
Fix nil reference error when starting Tempo (#2444)
0de7cca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@xoscar xoscar xoscar approved these changes

@schoren schoren Awaiting requested review from schoren

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielbdias @jorgeepc @xoscar